Skip to content

Private key management - Remove Key sharing / threshold signatures scheme - #397

Merged
GBKS merged 8 commits into
masterfrom
pkm/remove-split-keys
Jun 15, 2021
Merged

GBKS merged 8 commits into
masterfrom
pkm/remove-split-keys

Conversation

@danielnordh

Copy link
Copy Markdown
Contributor

As discussed in #313 we no longer want to promote or include this scheme.

This PR removes the page, any links to it and mentions of the scheme, any images used and updates an illustration to remove the scheme.

@danielnordh danielnordh changed the title Private key management - Remove Key sharing / threshold signatures Private key management - Remove Key sharing / threshold signatures scheme Jun 11, 2021
@danielnordh
danielnordh requested review from GBKS and pavlenex June 11, 2021 15:57
@Bosch-0

Bosch-0 commented Jun 12, 2021

Copy link
Copy Markdown
Collaborator

For another PR, but relevant to this, we should add non-recommended schemes in the overview PKM page and link to external sources. This as well as WIF backups are things we can have there.

Bosch-0
Bosch-0 previously approved these changes Jun 12, 2021

@Bosch-0 Bosch-0 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

pavlenex
pavlenex previously approved these changes Jun 14, 2021

@GBKS GBKS left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think something went wrong as a few images were deleted from other pages that still use them. There are also 2 .icloud files that were committed. Could you please double-check?

@danielnordh
danielnordh dismissed stale reviews from pavlenex and Bosch-0 via 0fa6828 June 14, 2021 18:13
@danielnordh

Copy link
Copy Markdown
Contributor Author

Thanks for spotting that @GBKS. (Have now turned off the iCloud optimization that was messing with the folder content).
Reverted and applied the changes without the mistakes.

@pavlenex
pavlenex requested a review from GBKS June 15, 2021 07:49

@GBKS GBKS left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also delete the unused wallet-recovery.md file?

@danielnordh

Copy link
Copy Markdown
Contributor Author

That is completely unrelated to this PR. But sure.

@GBKS GBKS left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for accommodating my last request. Let's get this merged.

@GBKS
GBKS merged commit e223024 into master Jun 15, 2021
@danielnordh
danielnordh deleted the pkm/remove-split-keys branch September 17, 2021 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants